Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: codegen value store and load & add debug info for the entire module #1126

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: codegen value store and load & add debug info for the entire module

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/backtrack.rs
  • kclvm/compiler/src/codegen/llvm/context.rs
  • kclvm/compiler/src/codegen/llvm/metadata.rs
  • kclvm/compiler/src/codegen/llvm/mod.rs
  • kclvm/compiler/src/codegen/llvm/emit.rs
  • kclvm/compiler/src/codegen/llvm/module.rs
  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/compiler/src/codegen/llvm/schema.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/lambda/in_schema_6/main.k
  • test/grammar/lambda/in_schema_7/main.k

@Peefy Peefy added this to the v0.9.0 Release milestone Mar 12, 2024
@Peefy Peefy requested review from zong-zhe and He1pa March 12, 2024 06:03
@Peefy Peefy force-pushed the refactor-codegen-value-load-store branch from 9d7d3d2 to 978a643 Compare March 12, 2024 06:35
…e module

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the refactor-codegen-value-load-store branch from 978a643 to 778168a Compare March 12, 2024 08:45
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 61a05fe into kcl-lang:main Mar 12, 2024
7 of 8 checks passed
@Peefy Peefy deleted the refactor-codegen-value-load-store branch March 12, 2024 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants