Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lsp vfs and db dead lock. #1159

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Mar 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/request.rs
kclvm/tools/src/LSP/src/state.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

dead lock cause by

process_vfs_changes() -> db.write() (lock) -> compile -> vfs.read() (block)
handle_x_request ()-> vfs.read() (lock)get_db()(block)
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8418210799

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.277%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/state.rs 1 3 33.33%
Totals Coverage Status
Change from base Build 8414900581: 0.0%
Covered Lines: 45116
Relevant Lines: 62421

💛 - Coveralls

@Peefy Peefy merged commit 3348890 into kcl-lang:main Mar 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants