Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting of unsaved changes in LSP #1173

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

vemoo
Copy link
Contributor

@vemoo vemoo commented Mar 28, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/tools/src/LSP/src/request.rs
  • kclvm/tools/src/LSP/src/tests.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@vemoo vemoo changed the title fix formating of unsaved changes in LSP fix formatting of unsaved changes in LSP Mar 28, 2024
Signed-off-by: Bernardo Uriarte <berublan@gmail.com>
Signed-off-by: Bernardo Uriarte <berublan@gmail.com>
Copy link

github-actions bot commented Mar 28, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@coveralls
Copy link
Collaborator

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8470695994

Details

  • 78 of 78 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 72.364%

Totals Coverage Status
Change from base Build 8469292050: 0.03%
Covered Lines: 47402
Relevant Lines: 65505

💛 - Coveralls

@vemoo
Copy link
Contributor Author

vemoo commented Mar 28, 2024

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Mar 28, 2024
@Peefy
Copy link
Contributor

Peefy commented Mar 29, 2024

Thank you for the contribution. LGTM! cc @He1pa

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the lsp label Mar 29, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 29, 2024
@Peefy Peefy merged commit 2234ca8 into kcl-lang:main Mar 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants