Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl evaluator eval context snapshot to prevent self recursively calling panic #1211

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 9, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: impl evaluator eval context snapshot to prevent self recursively calling

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/src/func.rs
  • kclvm/evaluator/src/node.rs
  • kclvm/evaluator/src/rule.rs
  • kclvm/evaluator/src/schema.rs
  • kclvm/evaluator/src/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/irrelevant_order/relaxed_1/main.k
  • test/grammar/schema/irrelevant_order/simple_1/main.k

…y calling

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy changed the title feat: impl evaluator eval context snapshot to prevent self recursively calling feat: impl evaluator eval context snapshot to prevent self recursively calling panic Apr 9, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Apr 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8616740940

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 57 (33.33%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 72.584%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/node.rs 7 13 53.85%
kclvm/evaluator/src/func.rs 0 9 0.0%
kclvm/evaluator/src/rule.rs 0 11 0.0%
kclvm/evaluator/src/ty.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/evaluator/src/rule.rs 1 0.0%
kclvm/evaluator/src/func.rs 1 70.0%
Totals Coverage Status
Change from base Build 8614475957: 0.0%
Covered Lines: 47976
Relevant Lines: 66097

💛 - Coveralls

@Peefy Peefy merged commit 3c47be6 into kcl-lang:main Apr 9, 2024
7 of 8 checks passed
@Peefy Peefy deleted the feat-evluator-eval-ctx-snapshot branch April 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants