Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pcre2 deps #1220

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • chore: remove pcre2 deps

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/config/Cargo.toml
  • kclvm/config/src/path.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy merged commit 3582ed1 into kcl-lang:main Apr 15, 2024
7 of 8 checks passed
@Peefy Peefy deleted the chore-remove-pcre2-deps branch April 15, 2024 05:40
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8683624468

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 73.321%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 72.02%
kclvm/sema/src/builtin/option.rs 1 0.0%
kclvm/sema/src/core/scope.rs 3 65.58%
kclvm/sema/src/core/symbol.rs 3 46.34%
kclvm/ast/src/config.rs 7 0.0%
Totals Coverage Status
Change from base Build 8683186600: -0.02%
Covered Lines: 48977
Relevant Lines: 66798

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants