Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fork deprecated serde yaml and add more string quoting when serialize #1232

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re crossplane-contrib/function-kcl#78
re crossplane-contrib/provider-upjet-aws#1261

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…ialize

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the fork-deprecated-serde-yaml branch from dd6b665 to 562a915 Compare April 19, 2024 11:38
@Peefy Peefy merged commit de289b0 into kcl-lang:main Apr 19, 2024
7 of 8 checks passed
@Peefy Peefy deleted the fork-deprecated-serde-yaml branch April 19, 2024 12:09
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8752940506

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3613 of 6861 (52.66%) changed or added relevant lines in 23 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.9%) to 71.401%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/third-party/serde_yaml/src/path.rs 17 20 85.0%
kclvm/third-party/serde_yaml/src/loader.rs 71 75 94.67%
kclvm/third-party/serde_yaml/src/libyaml/tag.rs 6 13 46.15%
kclvm/third-party/serde_yaml/src/value/debug.rs 22 33 66.67%
kclvm/third-party/serde_yaml/src/value/partial_eq.rs 0 26 0.0%
kclvm/third-party/serde_yaml/src/value/from.rs 0 29 0.0%
kclvm/third-party/serde_yaml/src/libyaml/emitter.rs 101 135 74.81%
kclvm/third-party/serde_yaml/src/libyaml/parser.rs 81 116 69.83%
kclvm/third-party/serde_yaml/src/libyaml/cstr.rs 30 81 37.04%
kclvm/third-party/serde_yaml/src/libyaml/error.rs 46 111 41.44%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 72.02%
kclvm/ast/src/token.rs 1 58.9%
kclvm/ast/src/ast.rs 1 83.55%
kclvm/tools/src/LSP/src/state.rs 1 86.15%
kclvm/sema/src/core/symbol.rs 3 46.54%
Totals Coverage Status
Change from base Build 8752777335: -1.9%
Covered Lines: 52618
Relevant Lines: 73694

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants