Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the inconsistency in filename drive letters #1283

Merged
merged 7 commits into from
May 8, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented May 6, 2024

fix the inconsistency in filename drive letters in Windows caused bycanonicalize() function

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/parser/src/parser/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…d bycanonicalize() function

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added parser Issues or PRs related to kcl parser resolver lsp labels May 6, 2024
kclvm/parser/src/parser/mod.rs Outdated Show resolved Hide resolved
kclvm/parser/src/parser/mod.rs Outdated Show resolved Hide resolved
kclvm/parser/src/parser/mod.rs Show resolved Hide resolved
@Peefy Peefy added this to the v0.9.0 Release milestone May 6, 2024
Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8979050244

Details

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 71.176%

Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/parser/mod.rs 2 98.0%
Totals Coverage Status
Change from base Build 8978945723: 0.008%
Covered Lines: 52962
Relevant Lines: 74410

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8999210228

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.171%

Totals Coverage Status
Change from base Build 8994730680: 0.03%
Covered Lines: 53021
Relevant Lines: 74498

💛 - Coveralls

Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: he1pa <18012015693@163.com>
kclvm/utils/src/path.rs Outdated Show resolved Hide resolved
kclvm/parser/src/parser/mod.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the fix_ast_filename branch 2 times, most recently from 49a1bca to 111d629 Compare May 8, 2024 08:54
Signed-off-by: he1pa <18012015693@163.com>
@Peefy Peefy merged commit 63d695c into kcl-lang:main May 8, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp parser Issues or PRs related to kcl parser resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants