Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-base-error): add 'rustc_errors' and 'rustc_span' in 'CompilerBase/3rdparty' #141

Closed
wants to merge 1 commit into from
Closed

feat(compiler-base-error): add 'rustc_errors' and 'rustc_span' in 'CompilerBase/3rdparty' #141

wants to merge 1 commit into from

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Aug 9, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base/3rdparty/rustc_errors
compiler_base/3rdparty/rustc_span

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

This is the first step for Compiler-Base-Error in issue #115.

Reuse 'styled_buffer.rs' in 'rustc_errors', and 'styled_buffer.rs' has been modified to fit the feature of 'Compiler-Base'.

  • add method 'appendl()' and 'putl()' to 'StyledBuffer'.
  • replaced the 'enum Style' with 'trait Style' to support extending more styles.
  • add some test cases for 'StyledBuffer'.

Copy 'rustc_span' in kclvm to compiler_base/3rdparty.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The test case is in the 'compiler_base/lib.rs', and shows how the 'StyledBuffer' work.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…tions.

Reuse 'styled_buffer.rs' in 'rustc_errors', and 'styled_buffer.rs' has been modified to fit the feature of 'Compiler-Base'.
- add method 'appendl()' and 'putl()' to 'StyledBuffer'.
- replaced the 'enum Style' with 'trait Style' to support extending more styles.
- add some test cases for 'StyledBuffer'.

issue #115
@zong-zhe zong-zhe added enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat labels Aug 9, 2022
@zong-zhe zong-zhe added this to the v0.4.3 Release milestone Aug 9, 2022
@zong-zhe zong-zhe requested review from chai2010, Peefy, ldxdl and a team August 9, 2022 09:08
@zong-zhe zong-zhe self-assigned this Aug 9, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2824089938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.984%

Totals Coverage Status
Change from base Build 2800957292: 0.0%
Covered Lines: 21335
Relevant Lines: 36171

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe closed this Aug 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
@zong-zhe zong-zhe deleted the add-compiler-base-3rdparty branch August 15, 2022 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants