-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: KCL Lint(Rust ver.) #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Lint check in resolver. Main changes are: 1. mode.rs: Definition of `Linter`, the entry for lint check 2. combinedlintpass.rs: `CombinedLintPass` collects all the lints defined in the lints_def.rs 3. lints_def.rs: Defined the various lints and the corresponding lintpasses implementation 4. lintpass.rs: Definition of `Lintpass` 5. lint.rs: Definition of `Lint` 6. resolver/mode.rs: Call `lint_check_module` when recursively check the ast, and call `lint_check_scope` after check re KusionStack#109
Pull Request Test Coverage Report for Build 2879830177
💛 - Coveralls |
Peefy
reviewed
Aug 17, 2022
…function and remove unless `#[macro_expr]`
Peefy
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
zong-zhe
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
sema/lint
sema/resolver
ast/walker
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Add Lint check in resolver. Main changes are:
Linter
, the entry for lint checkCombinedLintPass
collects all the lints defined in the lints_def.rsLintpass
Lint
lint_check_module
when recursively check the ast, and calllint_check_scope
after check4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.