Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more functions and parameters for the datetime module #1605

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1602

feat: add more functions and parameters for the datetime module

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10571481265

Details

  • 3 of 34 (8.82%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 70.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/datetime/mod.rs 0 31 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/third-party/serde_yaml/src/de.rs 1 82.67%
kclvm/runtime/src/datetime/mod.rs 1 0.0%
Totals Coverage Status
Change from base Build 10564024767: -0.03%
Covered Lines: 51574
Relevant Lines: 72714

💛 - Coveralls

@Peefy Peefy merged commit 6b4458b into kcl-lang:main Aug 27, 2024
12 checks passed
@Peefy Peefy deleted the more-function-and-params-for-datetime-module branch August 27, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants