Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kclvm capi call #168

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Kclvm capi call #168

merged 3 commits into from
Aug 29, 2022

Conversation

NeverRaR
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

internal/kclvm_py/program/rpc-server/main.py
kclvm/parser/src/lib.rs
kclvm/runner/
kclvm/tools/src/query/

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

refactor: enhance kclvm runner error message.
chore: kclvm python server use kclvm dylib to run.
feat: sync python override api in rust

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
    kclvm/tools/src/query/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@NeverRaR NeverRaR requested review from Peefy and chai2010 and removed request for chai2010 August 29, 2022 05:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2946038267

  • 38 of 38 (100.0%) changed or added relevant lines in 7 files are covered.
  • 358 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 60.071%

Files with Coverage Reduction New Missed Lines %
kclvm/compiler/src/codegen/llvm/context.rs 358 74.15%
Totals Coverage Status
Change from base Build 2945273706: 0.6%
Covered Lines: 23000
Relevant Lines: 38288

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 6ecc9e0 into kcl-lang:main Aug 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants