Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler_base): fix warnings by 'cargo clippy' for Compiler_Base. #194

Merged
merged 1 commit into from
Sep 9, 2022
Merged

refactor(compiler_base): fix warnings by 'cargo clippy' for Compiler_Base. #194

merged 1 commit into from
Sep 9, 2022

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Sep 8, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

fix warnings by 'cargo clippy'

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added error-handling Issues or PRs related to kcl error handling feat refactor labels Sep 8, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Sep 8, 2022
@zong-zhe zong-zhe self-assigned this Sep 8, 2022
Peefy
Peefy previously approved these changes Sep 8, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

He1pa
He1pa previously approved these changes Sep 8, 2022
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zong-zhe zong-zhe dismissed stale reviews from He1pa and Peefy via 4093377 September 8, 2022 12:11
@coveralls
Copy link
Collaborator

coveralls commented Sep 8, 2022

Pull Request Test Coverage Report for Build 3014967698

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 60.421%

Totals Coverage Status
Change from base Build 3014203517: 0.003%
Covered Lines: 23790
Relevant Lines: 39374

💛 - Coveralls

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zong-zhe zong-zhe merged commit 47a3781 into kcl-lang:main Sep 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling feat refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants