Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(compiler-base-session): Add some method for 'Session'. #245

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Feat(compiler-base-session): Add some method for 'Session'. #245

merged 3 commits into from
Oct 18, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler-base-session

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

add constructor new_with_src_code() to 'Session' for constructing by source code.
add method 'emit_err()' to 'Session' for displaying error diagnostic.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added the feat label Oct 18, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 18, 2022
@zong-zhe zong-zhe self-assigned this Oct 18, 2022
@coveralls
Copy link
Collaborator

coveralls commented Oct 18, 2022

Pull Request Test Coverage Report for Build 3272016812

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1107 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.2%) to 59.675%

Files with Coverage Reduction New Missed Lines %
kclvm/3rdparty/rustc_span/src/source_map.rs 1 27.95%
kclvm/sema/src/resolver/schema.rs 2 80.99%
kclvm/sema/src/ty/mod.rs 35 66.02%
kclvm/3rdparty/rustc_span/src/analyze_source_file.rs 48 75.26%
kclvm/parser/src/lib.rs 54 83.69%
kclvm/sema/src/resolver/global.rs 294 61.42%
kclvm/sema/src/resolver/node.rs 298 69.25%
kclvm/3rdparty/rustc_span/src/lib.rs 375 33.75%
Totals Coverage Status
Change from base Build 3271916721: 0.2%
Covered Lines: 21875
Relevant Lines: 36657

💛 - Coveralls

add constructor `new_with_src_code()` to 'Session' for constructing by source code.
add method 'emit_err()' to 'Session' for displaying error diagnostic.

issue #115
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldxdl ldxdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldxdl ldxdl merged commit 9a2ef1a into kcl-lang:main Oct 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants