Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(compiler-base-error): impl trait Debug for DiagnosticHandler and DiagnosticHandlerInner. #259

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Feat(compiler-base-error): impl trait Debug for DiagnosticHandler and DiagnosticHandlerInner. #259

merged 2 commits into from
Oct 25, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler-base-error.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

impl trait Debug for DiagnosticHandler and DiagnosticHandlerInner.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

… DiagnosticHandlerInner.

impl trait Debug for DiagnosticHandler and DiagnosticHandlerInner.

issue #115
@zong-zhe zong-zhe added the feat label Oct 25, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 25, 2022
@zong-zhe zong-zhe self-assigned this Oct 25, 2022
@coveralls
Copy link
Collaborator

coveralls commented Oct 25, 2022

Pull Request Test Coverage Report for Build 3320305444

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-27.6%) to 61.241%

Totals Coverage Status
Change from base Build 3319983713: -27.6%
Covered Lines: 23898
Relevant Lines: 39023

💛 - Coveralls

Peefy
Peefy previously approved these changes Oct 25, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit e3bddea into kcl-lang:main Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants