Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unreasonable revealed parser error information to avoid parser throwing internal errors for parser error recovery. #436

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #57 and #420

refactor: unreasonable revealed parser error information to avoid parser throwing internal errors for parser error recovery.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm_parser crate

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

refactor: unreasonable revealed parser error information to avoid parser throwing internal errors for parser error recovery.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/parser/src/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…ser throwing internal errors for parser error recovery.
@Peefy Peefy added the parser Issues or PRs related to kcl parser label Mar 7, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 7, 2023
@Peefy Peefy self-assigned this Mar 7, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2023

Pull Request Test Coverage Report for Build 4351318664

  • 40 of 47 (85.11%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-27.006%) to 63.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/parser/mod.rs 1 2 50.0%
kclvm/parser/src/session/mod.rs 7 9 77.78%
kclvm/parser/src/parser/ty.rs 26 30 86.67%
Totals Coverage Status
Change from base Build 4350162382: -27.006%
Covered Lines: 21518
Relevant Lines: 33857

💛 - Coveralls

@Peefy Peefy added the refactor label Mar 7, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit d08be56 into kcl-lang:main Mar 7, 2023
@Peefy Peefy deleted the refactor-parser-error branch March 7, 2023 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
parser Issues or PRs related to kcl parser refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants