Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(compiler-base): Add default reporter function report_event_shott_message and report_event_details based on fern. #472

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

compiler_base_parallel.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…t_message` and `report_event_details` based on `fern`.
@zong-zhe zong-zhe added this to the v0.4.6 Release milestone Mar 28, 2023
@zong-zhe zong-zhe self-assigned this Mar 28, 2023
Peefy
Peefy previously approved these changes Mar 28, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Mar 28, 2023

Pull Request Test Coverage Report for Build 4540376679

  • 199 of 268 (74.25%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 87.988%

Changes Missing Coverage Covered Lines Changed/Added Lines %
compiler_base/parallel/src/task/event.rs 5 12 41.67%
compiler_base/parallel/src/task/mod.rs 17 29 58.62%
compiler_base/parallel/src/task/reporter.rs 176 226 77.88%
Totals Coverage Status
Change from base Build 4539004975: -1.3%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0be11b5 into kcl-lang:main Mar 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants