Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add more position information for the ast identifier node #485

Closed
wants to merge 1 commit into from

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 4, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #420

feat: add more position information for the ast identifier node

2. What is the scope of this PR (e.g. component or file name):

  • kclvm_ast crate
  • kclvm_parser crate

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • unit test cases at kclvm/parser/src/tests/snapshots/**.snap

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added parser Issues or PRs related to kcl parser ast labels Apr 4, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Apr 4, 2023
@Peefy Peefy self-assigned this Apr 4, 2023
@coveralls
Copy link
Collaborator

coveralls commented Apr 4, 2023

Pull Request Test Coverage Report for Build 4607178899

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 4596082952: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@Peefy Peefy modified the milestones: v0.4.6 Release, v0.5.0 Release Apr 10, 2023
@Peefy Peefy closed this May 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ast parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants