Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add github download badge #639

Merged
merged 1 commit into from
Aug 4, 2023
Merged

chore: add github download badge #639

merged 1 commit into from
Aug 4, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 4, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • chore: add github download badge
  • README-zh.md
  • README.md

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added the chore label Aug 4, 2023
@Peefy Peefy requested a review from zong-zhe August 4, 2023 05:37
@Peefy Peefy self-assigned this Aug 4, 2023
zong-zhe
zong-zhe approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1e0c6c7 into kcl-lang:main Aug 4, 2023
10 checks passed
@Peefy Peefy deleted the add-download-badge branch August 4, 2023 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees

@Peefy Peefy

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peefy @zong-zhe