Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type annotation check during type checking in assignment #757

Merged
merged 6 commits into from Oct 12, 2023
Merged

fix: add type annotation check during type checking in assignment #757

merged 6 commits into from Oct 12, 2023

Conversation

zong-zhe
Copy link
Contributor

Signed-off-by: zongz zongzhe1024@163.com

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixes #746

2. What is the scope of this PR (e.g. component or file name):

add type annotation check during type checking in assignment.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the bug Something isn't working label Oct 10, 2023
@zong-zhe zong-zhe added this to the v0.7.0 Release milestone Oct 10, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy October 10, 2023 12:26
@zong-zhe zong-zhe self-assigned this Oct 10, 2023
@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2023

Pull Request Test Coverage Report for Build 6483301932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 6480079094: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy Peefy merged commit e13ef0e into kcl-lang:main Oct 12, 2023
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Copy link
Contributor

@i-zhen i-zhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Bug] Type infer error for variable with the type annotation
4 participants