Skip to content

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Aug 3, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix issue #132

2. What is the scope of this PR (e.g. component or file name):

README-zh.md
README.md
docs/kcl_mod-zh.md
docs/kcl_mod.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the documentation Improvements or additions to documentation label Aug 3, 2023
@zong-zhe zong-zhe self-assigned this Aug 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5863544686

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 39.835%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/cmd_run.go 9 0%
pkg/cmd/cmd_pull.go 12 0%
Totals Coverage Status
Change from base Build 5722318220: 0.0%
Covered Lines: 1011
Relevant Lines: 2538

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f755f2d into kcl-lang:main Aug 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants