Skip to content

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe requested review from Peefy, He1pa and Copilot April 21, 2025 07:55
@zong-zhe zong-zhe self-assigned this Apr 21, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Kotlin version to 0.11.2 and updates the API usage to use property access rather than explicit getter and setter methods.

  • Update calls from _builder.getXXX()/setXXX() to _builder.xxx in all relevant API files
  • Bump version numbers in Cargo.toml and README to reflect the new release

Reviewed Changes

Copilot reviewed 69 out of 70 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kotlin/src/main/kotlin/com/kcl/api/GetSchemaTypeMapping_ResultKt.kt Replaces _builder.getSchemaTypeMappingMap() with _builder.schemaTypeMappingMap
kotlin/src/main/kotlin/com/kcl/api/GetSchemaTypeMapping_ArgsKt.kt Updates getter/setter for execArgs and schemaName using property access
kotlin/src/main/kotlin/com/kcl/api/FormatPath_ResultKt.kt Changes getChangedPathsList() to property access (_builder.changedPathsList)
kotlin/src/main/kotlin/com/kcl/api/FormatPath_ArgsKt.kt Updates getter/setter for path property via _builder.path
kotlin/src/main/kotlin/com/kcl/api/FormatCode_ResultKt.kt Changes getFormatted() to property access (_builder.formatted)
kotlin/src/main/kotlin/com/kcl/api/FormatCode_ArgsKt.kt Updates getSource()/setSource() to _builder.source
kotlin/src/main/kotlin/com/kcl/api/ExternalPkgKt.kt Updates pkgName and pkgPath access to use properties
kotlin/src/main/kotlin/com/kcl/api/ExecProgram_ResultKt.kt Updates jsonResult, yamlResult, logMessage, and errMessage properties
kotlin/src/main/kotlin/com/kcl/api/ExecProgram_ArgsKt.kt Updates multiple getter/setter calls, replacing with property access for workDir, kFilenameList, kCodeList, args, overrides, disableYamlResult, printOverrideAst, strictRangeCheck, disableNone, verbose, debug, sortKeys, externalPkgs, includeSchemaTypePath, compileOnly, and fastEval
kotlin/src/main/kotlin/com/kcl/api/ExecArtifact_ArgsKt.kt Changes for path and execArgs properties with property access
kotlin/src/main/kotlin/com/kcl/api/ExampleKt.kt Updates summary, description, and value access via properties
kotlin/src/main/kotlin/com/kcl/api/ErrorKt.kt Changes level, code, and messages access to the new property style
kotlin/src/main/kotlin/com/kcl/api/DecoratorKt.kt Updates name and arguments/keywords access with property style
kotlin/src/main/kotlin/com/kcl/api/CliConfigKt.kt Replaces getter methods with property access for files, output, overrides, pathSelector, strictRangeCheck, disableNone, verbose, debug, sortKeys, showHidden, and includeSchemaTypePath
kotlin/src/main/kotlin/com/kcl/api/BuildProgram_ResultKt.kt Updates path getter/setter to use property access
kotlin/src/main/kotlin/com/kcl/api/BuildProgram_ArgsKt.kt Updates execArgs and output access to property style
kotlin/src/main/kotlin/com/kcl/api/ArgumentKt.kt Replaces getName()/getValue() with property access
kotlin/README.md Bumps version from 0.11.1-SNAPSHOT to 0.11.2-SNAPSHOT
kotlin/Cargo.toml Updates package version and dependency versions to 0.11.2
Files not reviewed (1)
  • kotlin/pom.xml: Language not supported

Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He1pa He1pa merged commit cb338a3 into kcl-lang:main Apr 21, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this to Done in KCL 2025 Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants