Skip to content

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 6, 2025

Summary

This PR adds:

The api-syncagent's GH action uses actions/upload-artifact@v4 instead of cytopia/upload-artifact-retry-action@v0.1.7 as the latter is unmaintained (see kcp-dev/kcp#3309).

Release Notes

NONE

/assign @xrstf @mjudeikis

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kcp-ci-bot kcp-ci-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 6, 2025
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2025
@mjudeikis
Copy link

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 528e7e5f096a6fa9959f3a50bbb81b2673e6463a

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@kcp-ci-bot kcp-ci-bot requested review from mjudeikis and xrstf March 6, 2025 12:26
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2025
@xmudrii xmudrii force-pushed the release-action branch 3 times, most recently from 1bb66fb to 69f2642 Compare March 6, 2025 12:41
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f00d159bb9b036b958dc675ec2f5f29f61cc2f9

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@kcp-ci-bot kcp-ci-bot merged commit 52642f9 into kcp-dev:main Mar 6, 2025
12 checks passed
@xmudrii xmudrii deleted the release-action branch March 6, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants