Skip to content

Conversation

tnthornton
Copy link

Rebased kcp-0.18 on top of kcp-0.19 (currently the branch from upstream).

This is currently needed for two reasons:

Pull in lastest changes from controller-runtime.
There was a signature change in utilruntime.PanicHandlers (0.31.0)

NOTE: supersedes #59

@kcp-ci-bot kcp-ci-bot added the dco-signoff: no Indicates the PR's author has not signed the DCO. label Sep 23, 2024
@tnthornton tnthornton force-pushed the tnthornton-kcp-0.19-take-2 branch from 0479fc7 to 94127e1 Compare September 23, 2024 16:36
@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2024
@tnthornton tnthornton force-pushed the tnthornton-kcp-0.19-take-2 branch from 94127e1 to e744ff6 Compare September 23, 2024 16:36
sbueringer and others added 7 commits September 23, 2024 09:46
Signed-off-by: tnthornton <2375126+tnthornton@users.noreply.github.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@tnthornton tnthornton force-pushed the tnthornton-kcp-0.19-take-2 branch from e744ff6 to bc184ec Compare September 23, 2024 16:47
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Sep 23, 2024
@tnthornton
Copy link
Author

/retest

@tnthornton tnthornton force-pushed the tnthornton-kcp-0.19-take-2 branch from bc184ec to dbdecbc Compare September 23, 2024 17:06
Signed-off-by: tnthornton <2375126+tnthornton@users.noreply.github.com>
@tnthornton tnthornton force-pushed the tnthornton-kcp-0.19-take-2 branch from dbdecbc to 73cc71a Compare September 23, 2024 17:38
Signed-off-by: tnthornton <2375126+tnthornton@users.noreply.github.com>
@tnthornton tnthornton force-pushed the tnthornton-kcp-0.19-take-2 branch from 40ca541 to 0f609a8 Compare September 23, 2024 17:46
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: 2b2452f8a01227c9ad9af3791f086f6bbdec1c57

@sttts
Copy link
Member

sttts commented Sep 23, 2024

/approve

@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts sttts merged commit fd7cd5b into kcp-dev:kcp-0.19 Sep 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants