Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync objects with kcp.dev/cluster label #71

Merged
merged 1 commit into from
May 11, 2021
Merged

Sync objects with kcp.dev/cluster label #71

merged 1 commit into from
May 11, 2021

Conversation

imjasonh
Copy link
Contributor

@imjasonh imjasonh requested a review from davidfestal May 11, 2021 13:16
davidfestal
davidfestal reviewed May 11, 2021
View reviewed changes
Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the owned-by ? is it specific to KCP or a well-known annotation ?
Additionally what's the use of the owned-by annotation knowing that the owner reference it set ?

@imjasonh
Sync objects with kcp.dev/cluster label
4918b43 
Also kcp.dev/-prefix the owned-by label.
@imjasonh
Copy link
Contributor Author

What about the owned-by ? is it specific to KCP or a well-known annotation ?
Additionally what's the use of the owned-by annotation knowing that the owner reference it set ?

Good call, done.

@imjasonh imjasonh merged commit 4dbaa92 into kcp-dev:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal davidfestal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix syncer cluster label with kcp.dev/
2 participants
@imjasonh @davidfestal