btrfs-progs-6.16.1/cmds/qgroup.c: 4 * mixup between | and || ?

[dcb314]

Static analyser cppcheck says:

btrfs-progs-6.16.1/cmds/qgroup.c:459:65: style: inconclusive: Boolean expression 'i==BTRFS_QGROUP_CHILD' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]
btrfs-progs-6.16.1/cmds/qgroup.c:471:65: style: inconclusive: Boolean expression 'i==BTRFS_QGROUP_CHILD' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]
btrfs-progs-6.16.1/cmds/qgroup.c:459:36: style: inconclusive: Boolean expression 'i==BTRFS_QGROUP_QGROUPID' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]
btrfs-progs-6.16.1/cmds/qgroup.c:471:36: style: inconclusive: Boolean expression 'i==BTRFS_QGROUP_QGROUPID' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]

The first one is

    if ((i == BTRFS_QGROUP_QGROUPID) | (i == BTRFS_QGROUP_PARENT) |
        (i == BTRFS_QGROUP_CHILD))

[kdave]

Thanks, this is IMO a clear miuse of bit op in place of logical operator, first added in 4d13434 . Feel free to send a fix.

[kdave]

Fixed in devel.