Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put project into maintence if some jobs are running there #56

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

pivnicek
Copy link
Contributor

@pivnicek pivnicek commented Sep 5, 2023

Changes:

  • The purpose here is to skip the project if it is found to have some jobs running. Then jobs can be terminated manually by the user before being put back into maintenance. This should help avoid situations such as https://github.com/keboola/devops/issues/653

Additional notes

⚠️ Don't forget to release new version after merge

@pivnicek pivnicek changed the title Add option to terminate running jobs before disabling the project Don't put project into maintence if some jobs are running there Sep 6, 2023
Copy link
Member

@kacurez kacurez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

$output
);
if ($thereAreRunningJobs) {
continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to inform that the project has been skipped due to jobs still running in that project

@pivnicek pivnicek merged commit c28b225 into main Sep 8, 2023
1 check passed
@pivnicek pivnicek deleted the ES-61-terminate-jobs branch September 8, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants