Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-84 add command to remove user from organization projects #58

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

pivnicek
Copy link
Contributor

@pivnicek pivnicek commented Oct 3, 2023

Changes:


Additional notes

⚠️ Don't forget to release new version after merge

@tomasfejfar tomasfejfar requested a review from a team October 3, 2023 13:40
@tomasfejfar
Copy link
Contributor

I'm still behind on support tasks to review this properly, so adding other from KBC.

@pivnicek
Copy link
Contributor Author

pivnicek commented Oct 3, 2023

No worries, it's just prepared for that ticket, doesn't need to be merged to be used :-) . ah, I suppose I ought to either add it to the readme or replace the readme with "use the list command to list commands and for help on each command us the --help option"

Copy link
Contributor

@jirkasemmler jirkasemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. but shouldn't you also check if the user exists there as org admin and remove it? https://keboolamanagementapi.docs.apiary.io/#reference/organizations/organization-users/remove-a-user-from-organization

@pivnicek
Copy link
Contributor Author

pivnicek commented Oct 6, 2023

hmmm, that's a good question. I somehow think that the customer can manage that manually, whereas when you've got a ton of projects it makes sense to script it.

@pivnicek pivnicek merged commit 33c728f into main Oct 6, 2023
1 check passed
@pivnicek pivnicek deleted the ES-84-rm-user branch October 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants