Skip to content

Conversation

tomasfejfar
Copy link
Contributor

Fixes #49

@tomasfejfar tomasfejfar self-assigned this Oct 18, 2018
@tomasfejfar tomasfejfar requested review from odinuv and Actimel October 18, 2018 12:07
Copy link
Contributor

@Actimel Actimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Za me ok, jen mozna jinde v testech to muze zpusobit problem, ze ten manifest je PRETTY_PRINT.

@tomasfejfar
Copy link
Contributor Author

To je asi pravda. Dobrý catch, díky 👍

@tomasfejfar tomasfejfar force-pushed the tf2-manifest-json-file-helper branch from 50aedc9 to eb101b9 Compare October 18, 2018 15:03
@tomasfejfar
Copy link
Contributor Author

Upravil jsem na nepretty print, nechám projít testy a mergnu.

@tomasfejfar tomasfejfar merged commit e5fec6a into master Oct 18, 2018
@tomasfejfar tomasfejfar deleted the tf2-manifest-json-file-helper branch October 18, 2018 15:09
@odinuv
Copy link
Member

odinuv commented Oct 18, 2018

tak to nechapu proc je state file pretty print a manifest ne

@tomasfejfar
Copy link
Contributor Author

Protože state file je new feature. Formátovaný manifest by byl BC break.

@odinuv
Copy link
Member

odinuv commented Oct 18, 2018

proc by to byl bc break?

@tomasfejfar
Copy link
Contributor Author

Protože tam už předtím dumpování manifestu bylo a formátované nebylo.

@odinuv
Copy link
Member

odinuv commented Oct 18, 2018

a co? funkcne je to stejny, runneru je to jedno, neni duvod aby na to nekde neco spolihalo a i kdyby, tak se na to prijde pri updatu te konretni komponenty.

prece nebudeme uz na vecnost generovat jeden json pretty a druhy compressed

@Actimel
Copy link
Contributor

Actimel commented Oct 18, 2018

Ja jsem za ten pretty one. Hlavne kvuli tomu, ze kdyz debuguju testy, tak se v tom muzu dobre orientovat, oproti 1000 znaku dlouhemu radku.

Jak pise @odinuv, kde to je otestovane, tak na to prijdeme pri updatu konkretnich komponent. Kde na to testy nejsou, tak si toho ani nevsimneme. Tak jak tak muzeme byt v klidu, protoze to nic rozbit nemuze (doufam, ze nemame nejaky custom parser na json, ktery podporuje jen one liner 😃 )

I ten state.json puvodne byl one liner a ted jsme to prehoupli na pretty print.

@tomasfejfar
Copy link
Contributor Author

A je to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants