datatype support enum #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamVyborny
reviewed
Jun 18, 2024
src/Config/BaseConfig.php
Outdated
| return DatatypeSupport::NONE; | ||
| } | ||
| return $this->getStringValue(['storage', 'output', 'data_type_support'], (string) $env); | ||
| return DatatypeSupport::from($this->getStringValue(['storage', 'output', 'data_type_support'], (string) $env)); |
There was a problem hiding this comment.
tady by to chtělo asi odchytit vyhodit user exception, když to user přepíše v configu na non enum value
There was a problem hiding this comment.
tak tam može byt tryFrom aby to vrátilo null 🤔
There was a problem hiding this comment.
jo, to pak to fallbackne na ten default no.
There was a problem hiding this comment.
akorát bude potřeba vydat novů major verzi teda.
There was a problem hiding this comment.
Já bych spíš ten release 10 zrušil, tam bylo víc chyb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.