Skip to content

fix check of empty value at ManifestOptionsSchema::setName() #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix check of empty value at ManifestOptionsSchema::setName() #90

merged 1 commit into from
Jul 30, 2024

Conversation

novak-ji
Copy link
Contributor

@novak-ji novak-ji requested a review from AdamVyborny July 30, 2024 13:28
@novak-ji novak-ji marked this pull request as ready for review July 30, 2024 13:28
AdamVyborny
AdamVyborny approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@novak-ji novak-ji merged commit ed4ddea into master Jul 30, 2024
@novak-ji novak-ji deleted the novakjiri-fix-empty-setname branch July 30, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamVyborny AdamVyborny AdamVyborny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novak-ji @AdamVyborny