Skip to content

TER-66 incremental load on tables without PKs #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 16, 2022
Merged

TER-66 incremental load on tables without PKs #151

merged 8 commits into from
Nov 16, 2022

Conversation

jirkasemmler
Copy link
Contributor

@jirkasemmler jirkasemmler commented Nov 14, 2022 •
edited
Loading

Jira: TER-66

Before asking for review make sure that:

Incremental load without PK -> just INSERT INTO

  • trait for deleting table if exists (TD doesnt support it -> we need combination of two commands)

@jirkasemmler jirkasemmler changed the base branch from master to jirka-ter-64-td-dedup November 14, 2022 08:55
@jirkasemmler jirkasemmler changed the title TER-66 inc dedup TER-66 incremental dedup without on tables without PKs Nov 14, 2022
@jirkasemmler jirkasemmler changed the title TER-66 incremental dedup without on tables without PKs TER-66 incremental load on tables without PKs Nov 14, 2022
@martinjunger
Copy link
Contributor

👀

martinjunger
martinjunger suggested changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dobry, jen par veci...

Base automatically changed from jirka-ter-64-td-dedup to master November 15, 2022 20:25
@jirkasemmler jirkasemmler force-pushed the jirka-ter-66-inc-dedup branch from 7280af5 to 96560cb Compare November 15, 2022 20:38
martinjunger
martinjunger approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jirkasemmler jirkasemmler merged commit ad9ce4c into master Nov 16, 2022
@jirkasemmler jirkasemmler deleted the jirka-ter-66-inc-dedup branch November 16, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjunger martinjunger martinjunger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirkasemmler @martinjunger