Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH Agent adding keys in recycle bin #10516

Closed
oxivanisher opened this issue Mar 29, 2024 · 0 comments · Fixed by #10518
Closed

SSH Agent adding keys in recycle bin #10516

oxivanisher opened this issue Mar 29, 2024 · 0 comments · Fixed by #10518
Labels
bug feature: SSH agent
Milestone
v2.7.8

Comments

@oxivanisher
Copy link

oxivanisher commented Mar 29, 2024 •
edited
Loading

Overview

It seems that #1396 is happening again. It took me several hours to finally find which old key showed up (since i chose poor key comments). I can't tell if this occurred, because the key was stored in several sub-folders withing the trash.

Steps to Reproduce

  1. Add a SSH key to a subfolder (group)
  2. Select it to be added to the ssh-agent (pagent was not selected) but the "remove from agent" was not ticketd.
  3. Delete the folder
  4. The key will be shared to ssh-agent

Expected Behavior

A SSH-key within the trash folder should not be added to the ssh-agent (also not if it is in subfolders)

Actual Behavior

The SSH-key is added to the ssh-agent.

KeePassXC 2.7.7

Operating System: Windows + Linux for sure
Desktop Env: Gnome on Linux, Windows 11
Windowing System: Wayland
@droidmonkey droidmonkey added this to the v2.7.8 milestone Mar 29, 2024
@droidmonkey droidmonkey changed the title SSH Agent Add Trash Keys (again?) SSH Agent adding keys in recycle bin Mar 29, 2024
droidmonkey added a commit that referenced this issue Mar 29, 2024
@droidmonkey
Prevent SSH Agent from using entries in the recycle bin
6b85b50 
* Fixes #10516
* Also cleanup Group::isRecycled() code a little
@droidmonkey droidmonkey mentioned this issue Mar 29, 2024
Merged
droidmonkey added a commit that referenced this issue Mar 31, 2024
@droidmonkey
Prevent SSH Agent from using entries in the recycle bin
6d0ac38 
* Fixes #10516
* Also cleanup Group::isRecycled() code a little
droidmonkey added a commit that referenced this issue Apr 20, 2024
@droidmonkey
Prevent SSH Agent from using entries in the recycle bin
62fb83b 
* Fixes #10516
* Also cleanup Group::isRecycled() code a little
pull bot pushed a commit to shashinma/keepassxc that referenced this issue Apr 20, 2024
@droidmonkey @pull
Prevent SSH Agent from using entries in the recycle bin
cd59bb3 
* Fixes keepassxreboot#10516
* Also cleanup Group::isRecycled() code a little
pull bot pushed a commit to tigerwill90/keepassxc that referenced this issue Apr 21, 2024
@droidmonkey @pull
Prevent SSH Agent from using entries in the recycle bin
80b2727 
* Fixes keepassxreboot#10516
* Also cleanup Group::isRecycled() code a little
droidmonkey added a commit that referenced this issue Apr 28, 2024
@droidmonkey
Prevent SSH Agent from using entries in the recycle bin
d87f003 
* Fixes #10516
* Also cleanup Group::isRecycled() code a little
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature: SSH agent
Projects
None yet
Milestone
v2.7.8
Development

Successfully merging a pull request may close this issue.

Prevent SSH Agent from using entries in the recycle bin keepassxreboot/keepassxc
2 participants
@oxivanisher @droidmonkey