Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sumologic provider #1924

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Sep 15, 2024

Closes #1906
/claim #1906

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
Copy link

vercel bot commented Sep 15, 2024

@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

gitguardian bot commented Sep 15, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

πŸ”Ž Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Sumo Logic Keys 28b10a5 keep/providers/sumologic_provider/sumologic_provider.py View secret
- - Sumo Logic Keys cfd7ee6 keep/providers/sumologic_provider/sumologic_provider.py View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small comments + ask for screenshot

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Sep 15, 2024

@talboren
image

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Sep 15, 2024

@talboren thanks for the review, I've made the required changes :)

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 69.75%. Comparing base (6d5c759) to head (d2c9fcc).
Report is 97 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1924       +/-   ##
===========================================
+ Coverage   30.68%   69.75%   +39.07%     
===========================================
  Files          54      143       +89     
  Lines        5028    11696     +6668     
===========================================
+ Hits         1543     8159     +6616     
- Misses       3485     3537       +52     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
keep βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 15, 2024 2:34pm

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talboren talboren enabled auto-merge (squash) September 15, 2024 14:33
@talboren talboren merged commit 9a5a7ee into keephq:main Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ”Œ Provider]: Add SumoLogic provider
2 participants