[WIP] Start to work on raycast & line #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts and fixes 1 when merging a5352a9 into c343554 - view on LGTM.com new alerts:
fixed alerts:
|
kefniark
commented
Nov 25, 2019
| const diffX = h * 0.5 - (source.x - Math.round(source.x)) | ||
| for (let i = 0; i < max; i++) { | ||
| const x = diffX + i * h | ||
| const y = x * Math.tan((angle * Math.PI) / 180) |
There was a problem hiding this comment.
this Math.tan value is always the same, can be put outside of the for loop
kefniark
commented
Nov 25, 2019
| const diffY = v * 0.5 - (source.y - Math.round(source.y)) | ||
| for (let j = 0; j < max; j++) { | ||
| const y = diffY + j * v | ||
| const x = y / Math.tan((angle * Math.PI) / 180) |
|
Started to move the sample to pixi, looks the same so far, except I switched to pixel perfect rendering in 192x192
|
|
Interesting ... increasing the amount of raycast every frame, I noticed that few lines manage to go through object 🤔 (following gif with 192 raycast)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work on selection and colision
Issue
Screenshot