Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

Add semicolon support. #15

Merged
merged 1 commit into from
Jul 8, 2012
Merged

Add semicolon support. #15

merged 1 commit into from
Jul 8, 2012

Conversation

brihogan
Copy link
Contributor

@brihogan brihogan commented Jul 8, 2012

Uncommented semicolon support and added the keyword semicolon. Not sure if the keyword is helpful, just following your protocol.

@brihogan
Copy link
Contributor Author

brihogan commented Jul 8, 2012

I hope I did this right. This is my first pull request.

keithamus added a commit that referenced this pull request Jul 8, 2012
@keithamus keithamus merged commit bb0b313 into keithamus:master Jul 8, 2012
@keithamus
Copy link
Owner

Perfectly executed pull request!

@brihogan
Copy link
Contributor Author

brihogan commented Jul 8, 2012

Thanks!

I closed the other issue (the original message). But, for future reference, do you know if there's a way to "combine" a pull request and an issue together so that they don't have to be closed separately? Or at least, can they be linked somehow?

@keithamus
Copy link
Owner

When you create a pull request it will create a new issue in the issue tracker, which you can use to describe the issue at hand (and also bundle the solution as well).

If there is an existing issue, which you intend to close with your pull request, add "fixes #NN" to the commit message, where NN is the issue number. When the pull request is accepted it will automatically close issue NN.

@brihogan
Copy link
Contributor Author

brihogan commented Jul 8, 2012

Brilliant. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants