Added fractional knapsack #729
Conversation
Added fractional knapsack under the greedy.
README.md
Outdated
| @@ -51,7 +51,8 @@ If you want to uninstall algorithms, it is as simple as: | |||
| $ pip3 uninstall -y algorithms | |||
|
|
|||
| ## List of Implementations | |||
|
|
|||
| - [Greedy](algorithms/arrays) | |||
There was a problem hiding this comment.
The elements are listed in alphabetical order. Could you add it below dp?
There was a problem hiding this comment.
ok no issues I will do it
|
|
||
| """Time Complexity O(n log n)""" | ||
| @staticmethod | ||
| def getMaxValue(wt, val, capacity): |
what do you mean by some unit test cases? |
I have added the greedy below the Dp as you requested.
I have made the necessary changes as requested for the snake case in my code.
To add test cases under the test folder, check this PR as guide |
I am new to open-source I don't know how to proceed with the test folder. |
There was a problem hiding this comment.
Also add some unit tests
what do you mean by some unit test cases?
To add test cases under the test folder, check this PR as guide
I am new to open-source I don't know how to proceed with the test folder.
Refer to python unittest, this is to add some test cases for your code/functions.
|
|
||
| """Time Complexity O(n log n)""" | ||
| @staticmethod | ||
| def get_Max_Value(wt, val, capacity): |
There was a problem hiding this comment.
change to snake case with lower case get_Max_Value -> get_max_value
As requested I have changed get_Max_Value->get_max_value
I have made all necessary changes as asked by you pls allow me to merge my pull request. |
|
|
Pls add hacktoberfest label also to this pull request |
|
pls allow me to merge |
|
thanks for merging |
I have added fractional knapsack code under greedy. Given the weights and values of n items, we need to put these items in a knapsack of capacity W to get the maximum total value in the knapsack. In Fractional Knapsack, we can break items for maximizing the total value of the knapsack.