Skip to content

Conversation

kartikeyg0104
Copy link
Contributor

What has changed?

The CSS styling in the Product.js file has been updated to improve spacing, alignment, and responsiveness. Specifically:

  • Adjusted margins for better spacing between sections (mb-4 to mb-6, mt-12 to mt-14).
  • Updated grid layout for better responsiveness (sm:grid-cols-3 changed to sm:grid-cols-1 md:grid-cols-2 xl:grid-cols-3).
  • Enhanced text readability by adding leading-relaxed to paragraphs.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

Screenshots

Screenshot 2025-09-15 at 9 04 48 PM Screenshot 2025-09-15 at 9 06 27 PM

How Has This Been Tested?

The changes have been tested by running the following commands:

  1. npm run build - Ensured the project builds successfully without errors.
  2. npm run serve - Verified that the changes are reflected correctly in the development server.

Screenshots of the output of both commands and the rendered Products section in the browser have been included.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 15:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CSS styling in the KeployCloud component to improve the layout and alignment of the "Questions?" section in the docs website. The changes focus on enhancing spacing, positioning, and visual appearance.

  • Improved spacing and positioning with adjusted margins and padding
  • Enhanced visual styling with shadow effects and refined text alignment
  • Better responsive layout adjustments for the questions section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<section
id="cloud"
className="mb-8 mt-12 flex max-w-7xl items-center space-x-5 rounded-lg bg-[color:var(--ifm-card-background-color)] p-5"
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md -ml-2"
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negative margin -ml-2 at the container level may cause layout issues or content to extend beyond its intended boundaries. Consider using proper padding or container adjustments instead of negative margins for positioning.

Suggested change
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md -ml-2"
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md"

Copilot uses AI. Check for mistakes.

Comment on lines 7 to 11
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md -ml-2"
>
<div className="prose prose-orange mx-auto max-w-3xl">
<h1> Question? 🤔💭</h1>
<p className="my-3 block">
<div className="prose prose-orange ml-0 max-w-3xl text-left">
<h1 className="text-left -ml-2"> Question? 🤔💭</h1>
<p className="my-3 block text-left -ml-0.5">
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple negative margins (-ml-2, -ml-0.5) and redundant text-left classes suggest inconsistent spacing approach. Consider using a consistent spacing system and removing redundant alignment classes since text-left is already applied to the parent div.

Copilot uses AI. Check for mistakes.

- Remove negative margins (-ml-2, -ml-0.5) causing misalignment
- Increase padding from p-4 to p-6 for better spacing
- Fix typo: Question? -> Questions?
- Remove unnecessary ml-0 class
- Enhance visual consistency and proper alignment

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kartikeyg0104 , the changes look really amazing! Just one small issue — it’s currently aligned fully to the left. Maybe you can add some spacing to make it look better.

I’ve provided a reference that you can follow. Could you please make this change?

Image

@kartikeyg0104
Copy link
Contributor Author

Okay, I am doing right away

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
@kartikeyg0104
Copy link
Contributor Author

Screenshot 2025-09-16 at 7 18 30 PM Sir, I have changed it, you can review once.

Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Achanandhi-M Achanandhi-M merged commit 7bb233c into keploy:main Sep 18, 2025
4 of 6 checks passed
Srinu346 pushed a commit to Srinu346/docs that referenced this pull request Sep 18, 2025
* fix: improve footer alignment for Questions section

- Remove negative margins (-ml-2, -ml-0.5) causing misalignment
- Increase padding from p-4 to p-6 for better spacing
- Fix typo: Question? -> Questions?
- Remove unnecessary ml-0 class
- Enhance visual consistency and proper alignment

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>

* fix: correct Questions section alignment by removing negative margins

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>

---------

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
Achanandhi-M pushed a commit that referenced this pull request Sep 30, 2025
* fix: improve footer alignment for Questions section

- Remove negative margins (-ml-2, -ml-0.5) causing misalignment
- Increase padding from p-4 to p-6 for better spacing
- Fix typo: Question? -> Questions?
- Remove unnecessary ml-0 class
- Enhance visual consistency and proper alignment

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>

* fix: correct Questions section alignment by removing negative margins

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>

---------

Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants