-
Notifications
You must be signed in to change notification settings - Fork 244
Footer alignment for ‘Questions?’ section in docs website #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates CSS styling in the KeployCloud component to improve the layout and alignment of the "Questions?" section in the docs website. The changes focus on enhancing spacing, positioning, and visual appearance.
- Improved spacing and positioning with adjusted margins and padding
- Enhanced visual styling with shadow effects and refined text alignment
- Better responsive layout adjustments for the questions section
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/KeployCloud.js
Outdated
<section | ||
id="cloud" | ||
className="mb-8 mt-12 flex max-w-7xl items-center space-x-5 rounded-lg bg-[color:var(--ifm-card-background-color)] p-5" | ||
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md -ml-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The negative margin -ml-2
at the container level may cause layout issues or content to extend beyond its intended boundaries. Consider using proper padding or container adjustments instead of negative margins for positioning.
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md -ml-2" | |
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md" |
Copilot uses AI. Check for mistakes.
src/components/KeployCloud.js
Outdated
className="mb-8 mt-12 flex max-w-7xl items-center space-x-6 rounded-lg bg-[color:var(--ifm-card-background-color)] p-4 shadow-md -ml-2" | ||
> | ||
<div className="prose prose-orange mx-auto max-w-3xl"> | ||
<h1> Question? 🤔💭</h1> | ||
<p className="my-3 block"> | ||
<div className="prose prose-orange ml-0 max-w-3xl text-left"> | ||
<h1 className="text-left -ml-2"> Question? 🤔💭</h1> | ||
<p className="my-3 block text-left -ml-0.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple negative margins (-ml-2
, -ml-0.5
) and redundant text-left
classes suggest inconsistent spacing approach. Consider using a consistent spacing system and removing redundant alignment classes since text-left
is already applied to the parent div.
Copilot uses AI. Check for mistakes.
- Remove negative margins (-ml-2, -ml-0.5) causing misalignment - Increase padding from p-4 to p-6 for better spacing - Fix typo: Question? -> Questions? - Remove unnecessary ml-0 class - Enhance visual consistency and proper alignment Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kartikeyg0104 , the changes look really amazing! Just one small issue — it’s currently aligned fully to the left. Maybe you can add some spacing to make it look better.
I’ve provided a reference that you can follow. Could you please make this change?

Okay, I am doing right away |
Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: improve footer alignment for Questions section - Remove negative margins (-ml-2, -ml-0.5) causing misalignment - Increase padding from p-4 to p-6 for better spacing - Fix typo: Question? -> Questions? - Remove unnecessary ml-0 class - Enhance visual consistency and proper alignment Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com> * fix: correct Questions section alignment by removing negative margins Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com> --------- Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com> Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
* fix: improve footer alignment for Questions section - Remove negative margins (-ml-2, -ml-0.5) causing misalignment - Increase padding from p-4 to p-6 for better spacing - Fix typo: Question? -> Questions? - Remove unnecessary ml-0 class - Enhance visual consistency and proper alignment Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com> * fix: correct Questions section alignment by removing negative margins Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com> --------- Signed-off-by: Kartikey Gupta <kartikeyf12@gmail.com>
What has changed?
The CSS styling in the
Product.js
file has been updated to improve spacing, alignment, and responsiveness. Specifically:mb-4
tomb-6
,mt-12
tomt-14
).sm:grid-cols-3
changed tosm:grid-cols-1 md:grid-cols-2 xl:grid-cols-3
).leading-relaxed
to paragraphs.Type of change
Please delete options that are not relevant.
Screenshots
How Has This Been Tested?
The changes have been tested by running the following commands:
npm run build
- Ensured the project builds successfully without errors.npm run serve
- Verified that the changes are reflected correctly in the development server.Screenshots of the output of both commands and the rendered
Products
section in the browser have been included.Checklist: