Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Subscription filter now correctly updates on delete/create service #7480

Merged

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Apr 14, 2022

Fixes #7402

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

…te service

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #7480 (a50c302) into master (9346d41) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7480      +/-   ##
==========================================
- Coverage   59.66%   59.49%   -0.17%     
==========================================
  Files         545      551       +6     
  Lines       31504    31548      +44     
  Branches     1590     1596       +6     
==========================================
- Hits        18797    18771      -26     
- Misses      11410    11476      +66     
- Partials     1297     1301       +4     
Impacted Files Coverage Δ
...ge/client/app/_services/_mockData/projects.mock.ts 100.00% <ø> (ø)
...ption/ktb-modify-uniform-subscription.component.ts 93.16% <100.00%> (+0.31%) ⬆️
...ktb-stage-overview/ktb-stage-overview.component.ts 31.42% <0.00%> (-40.00%) ⬇️
...s/ktb-stage-details/ktb-stage-details.component.ts 27.08% <0.00%> (-31.25%) ⬇️
...environment-view/ktb-environment-view.component.ts 84.61% <0.00%> (-15.39%) ⬇️
...ce-state-list/ktb-sequence-state-list.component.ts 76.08% <0.00%> (-15.22%) ⬇️
bridge/client/app/_models/stage.ts 56.00% <0.00%> (-14.00%) ⬇️
bridge/client/app/_models/project.ts 54.25% <0.00%> (-9.58%) ⬇️
bridge/client/app/_services/api.service.mock.ts 70.12% <0.00%> (-1.95%) ⬇️
...idge/client/app/app-header/app-header.component.ts 46.21% <0.00%> (-1.69%) ⬇️
... and 12 more
Flag Coverage Δ
bridge-server 67.09% <ø> (+0.36%) ⬆️
bridge2 73.90% <100.00%> (-0.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kirdock Kirdock merged commit fc7d3b4 into master Apr 15, 2022
@Kirdock Kirdock deleted the fix/7402/add-polling-for-subscription-service-filter branch April 15, 2022 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly created service is not available in Create Subscription page
2 participants