Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor contributing guide - general guidelines #1411

Merged
merged 9 commits into from
Jun 12, 2023

Conversation

YashPimple
Copy link
Member

Relate #972
Fixes #995

Resolved the markdown-lint issue

Signed-off-by: Yash Pimple yashpimple22@gmai.com

Signed-off-by: Yash Pimple <97302447+YashPimple@users.noreply.github.com>
@YashPimple YashPimple requested review from a team as code owners May 13, 2023 20:08
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 13, 2023
@netlify
Copy link

netlify bot commented May 13, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 3387402
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64871babcf8173000813415b
😎 Deploy Preview https://deploy-preview-1411--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@agardnerIT
Copy link
Contributor

agardnerIT commented May 18, 2023

I'm confused. I click the deploy preview netlify link above and then click Contributing in the top bar. I don't see your changes reflected?

@agardnerIT
Copy link
Contributor

Found it: homepage > contributing > General information about contributing > Contributing guidelines

@agardnerIT
Copy link
Contributor

HtmlTest and markdown link checks are failing. Please review the Details (by clicking the Details) link above, fix and once those checks are green we'll be on the way to an approval.

StackScribe
StackScribe previously approved these changes Jun 1, 2023
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
aepfli
aepfli previously approved these changes Jun 1, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies changed the title docs: update the general guidelines section docs: refactor contributing guide - general guidelines Jun 12, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 7170eec into keptn:main Jun 12, 2023
@keptn-bot keptn-bot mentioned this pull request Jun 12, 2023
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 19, 2023
Signed-off-by: Yash Pimple <97302447+YashPimple@users.noreply.github.com>
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Signed-off-by: Yash Pimple <97302447+YashPimple@users.noreply.github.com>
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing: general guidelines
6 participants