Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize generation of resource names #1472

Merged
merged 2 commits into from
May 26, 2023
Merged

chore: standardize generation of resource names #1472

merged 2 commits into from
May 26, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes: #1426

@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 74e2076
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/646f6b20969e3c0008065b30
😎 Deploy Preview https://deploy-preview-1472--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1472 (100c711) into main (a3f5e5b) will increase coverage by 0.11%.
The diff coverage is 90.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
+ Coverage   62.25%   62.37%   +0.11%     
==========================================
  Files         139      139              
  Lines       10634    10638       +4     
==========================================
+ Hits         6620     6635      +15     
+ Misses       3752     3743       -9     
+ Partials      262      260       -2     
Impacted Files Coverage Δ
operator/controllers/common/helperfunctions.go 98.61% <ø> (-0.04%) ⬇️
...rator/controllers/lifecycle/keptnapp/controller.go 64.10% <33.33%> (-0.61%) ⬇️
...ecycle/keptnappversion/reconcile_workloadsstate.go 92.64% <50.00%> (-0.11%) ⬇️
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 73.68% <86.95%> (+1.57%) ⬆️
operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <100.00%> (ø)
operator/apis/lifecycle/v1alpha3/keptnapp_types.go 93.33% <100.00%> (ø)
...tor/apis/lifecycle/v1alpha3/keptnworkload_types.go 93.93% <100.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 68.03% <100.00%> (-0.52%) ⬇️
scheduler/pkg/klcpermit/workflow_manager.go 63.24% <100.00%> (+11.02%) ⬆️
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.78% <16.66%> (+0.06%) ⬆️
lifecycle-operator 84.06% <83.33%> (+0.12%) ⬆️
metrics-operator 80.51% <ø> (ø)
scheduler 30.45% <100.00%> (+8.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review May 26, 2023 05:53
@odubajDT odubajDT requested a review from a team as a code owner May 26, 2023 05:53
operator/common/common.go Outdated Show resolved Hide resolved
operator/common/common.go Outdated Show resolved Hide resolved
operator/common/common.go Outdated Show resolved Hide resolved
bacherfl
bacherfl previously approved these changes May 26, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked integration test names and LGTM 🚀

@odubajDT odubajDT merged commit f7abcb0 into keptn:main May 26, 2023
@keptn-bot keptn-bot mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate generated KeptnWorkload/KeptnWorkloadInstance names when those objects are created
3 participants