Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some sonarcloud settings #1018

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix: fix some sonarcloud settings #1018

merged 2 commits into from
Mar 9, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 9, 2023

This PR

  • fixes some settings in our sonar project settings

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1d86c50
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6409a7f70d829200082e0ec9
😎 Deploy Preview https://deploy-preview-1018--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bacherfl
bacherfl previously approved these changes Mar 9, 2023
thisthat
thisthat previously approved these changes Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1018 (58a7060) into main (4bf2919) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   59.17%   59.21%   +0.04%     
==========================================
  Files         124      124              
  Lines        9904     9904              
==========================================
+ Hits         5861     5865       +4     
+ Misses       3836     3833       -3     
+ Partials      207      206       -1     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 82.95% <0.00%> (+1.79%) ⬆️
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 54.64% <ø> (+0.53%) ⬆️
lifecycle-operator 78.39% <ø> (ø)
metrics-operator 77.64% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies dismissed stale reviews from thisthat and bacherfl via 58a7060 March 9, 2023 09:37
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies merged commit a40a8d3 into keptn:main Mar 9, 2023
@mowies mowies deleted the sonar-fixes branch March 9, 2023 09:56
@keptn-bot keptn-bot mentioned this pull request Mar 9, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants