-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add documentation for keptn.sh/container annotation #2500
Conversation
Signed-off-by: Norman <85173861+norman-zon@users.noreply.github.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mowies , I am not too sure about appending the container annotation to the list, because there is no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I left a couple small editorial suggestions but otherwise, this is ready to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments to make the lint checks for MD files passing :)
Otherwise, LGTM content-wise :)
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com> Signed-off-by: Norman <85173861+norman-zon@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: Norman <85173861+norman-zon@users.noreply.github.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com> Signed-off-by: Norman <85173861+norman-zon@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Summary
If a pod contains multiple containers the user can select which container the version should be extracted from by setting the keptn.sh/container annotation. If the annotation is set, but no container matches its name we assume something is wrong an throw an error.
Fixes #2484
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview