Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): introduce non-blocking deployment functionality for application lifecycle #3113

Merged
merged 14 commits into from
Feb 26, 2024
Merged

feat(lifecycle-operator): introduce non-blocking deployment functionality for application lifecycle #3113

merged 14 commits into from
Feb 26, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Feb 23, 2024

Part-of: #1934

Changes

  • adapted controller's functionality to support non-blocking deployment
  • adapted api functions to support non-blocking deployment
  • fixed small bugs in controller's logic
  • unit tests
  • integration test
  • remove unneeded integration test

Traces

Traces with enabling the non-bocking feature shows failed tasks, but the parent traces (e.g. AppPreDeployTasks) are marked as successfull

Screenshot 2024-02-26 at 07 44 27

Note

CNCF Slack inviter is not working currently -> reason for the failing makrdown-link-check

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (ce57993) to head (3e87685).
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
+ Coverage   85.75%   86.77%   +1.02%     
==========================================
  Files         162      162              
  Lines       10351     8590    -1761     
==========================================
- Hits         8876     7454    -1422     
+ Misses       1186      844     -342     
- Partials      289      292       +3     
Files Coverage Δ
...e-operator/apis/lifecycle/v1beta1/common/common.go 100.00% <100.00%> (ø)
...or/apis/lifecycle/v1beta1/keptnappversion_types.go 98.19% <100.00%> (+0.50%) ⬆️
...is/lifecycle/v1beta1/keptnworkloadversion_types.go 96.24% <100.00%> (+0.74%) ⬆️
...ontrollers/lifecycle/keptnappversion/controller.go 78.99% <100.00%> (+0.66%) ⬆️
...llers/lifecycle/keptnappversion/reconcile_phase.go 65.51% <100.00%> (ø)
...cle/keptnappversion/reconcile_prepostevaluation.go 63.15% <100.00%> (+0.65%) ⬆️
...llers/lifecycle/keptnworkloadversion/controller.go 90.73% <100.00%> (+1.58%) ⬆️
...eptnworkloadversion/reconcile_prepostdeployment.go 84.61% <100.00%> (+2.79%) ⬆️
...eptnworkloadversion/reconcile_prepostevaluation.go 89.47% <100.00%> (+1.97%) ⬆️

... and 130 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (+1.80%) ⬆️
component-tests 56.29% <84.61%> (+0.29%) ⬆️
keptn-lifecycle-operator ?
lifecycle-operator 86.45% <84.90%> (+1.16%) ⬆️
metrics-operator 88.32% <ø> (+0.68%) ⬆️
scheduler 34.74% <ø> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review February 26, 2024 06:58
@odubajDT odubajDT requested a review from a team as a code owner February 26, 2024 06:58
…lity for application lifecycle

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odubajDT odubajDT merged commit bf78974 into keptn:main Feb 26, 2024
36 of 37 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…lity for application lifecycle (keptn#3113)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants