Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validating webhook for Keptn Metrics #668

Merged
merged 13 commits into from
Jan 23, 2023
Merged

feat: add validating webhook for Keptn Metrics #668

merged 13 commits into from
Jan 23, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 20, 2023 •
edited
Loading

closes #662

How to test:

make build-deploy-dev-environment RELEASE_REGISTRY=yourrreg
kubectl apply -f test/integration/metrics/goodmetric.yaml
kubectl apply -f test/integration/metrics/badmetric.yaml

image

@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #668 (e27571d) into main (da8fcee) will increase coverage by 0.21%.
The diff coverage is 61.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   56.39%   56.61%   +0.21%     
==========================================
  Files          82       83       +1     
  Lines        6683     6753      +70     
==========================================
+ Hits         3769     3823      +54     
- Misses       2755     2770      +15     
- Partials      159      160       +1
Impacted Files Coverage Δ
...tor/apis/metrics/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...rator/apis/metrics/v1alpha1/keptnmetric_webhook.go 63.15% <63.15%> (ø)
...okcontroller/keptnwebhookcertificate_controller.go 53.84% <69.56%> (+3.02%) ⬆️
...rs/keptnwebhookcontroller/webhook_configuration.go 100.00% <100.00%> (ø)
...perator/apis/metrics/v1alpha1/keptnmetric_types.go 100.00% <100.00%> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 78.24% <0.00%> (+1.85%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 53.54% <ø> (+0.70%) ⬆️
keptn-cert-manager 68.35% <78.12%> (+0.78%) ⬆️
keptn-lifecycle-operator 52.10% <51.92%> (+0.08%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna
added validation webhook in operator
c432ca0 
Signed-off-by: realanna <anna.reale@dynatrace.com>

added validation webhook in operator

Signed-off-by: realanna <anna.reale@dynatrace.com>

added validation webhook in operator

Signed-off-by: realanna <anna.reale@dynatrace.com>

added validation webhook in operator

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
handle validation webhook in certmanager
373b158 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
add integration test
d769b7e 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
added tests
6207dd0 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna marked this pull request as ready for review January 20, 2023 13:54
@RealAnna @odubajDT
fixed after review
450203a 
Signed-off-by: realanna <anna.reale@dynatrace.com>

Update operator/apis/metrics/v1alpha1/keptnmetric_webhook.go

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
RealAnna and others added 2 commits January 23, 2023 11:08
@RealAnna @odubajDT
Update operator/apis/metrics/v1alpha1/keptnmetric_types.go
5f2afb4 
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
fixed after review
fef90b4 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fixed after review
d0fdcd0 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fixed after review
f6895eb 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fixed after review
ba949ba 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fixed after review
d4780ce 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fixed after review
ea7799d 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fixed after review
e27571d 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit a4cc579 into main Jan 23, 2023
@RealAnna RealAnna deleted the feat/662/validating_webhook branch January 23, 2023 12:03
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2023
Merged
@RealAnna RealAnna mentioned this pull request May 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat left review comments

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thschue thschue Awaiting requested review from thschue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Validating Webhook for KeptnMetric CRD
4 participants
@RealAnna @thisthat @bacherfl @odubajDT