Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create an helm overlay #697

Merged
merged 18 commits into from
Jan 30, 2023
Merged

feat: create an helm overlay #697

merged 18 commits into from
Jan 30, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 25, 2023 •
edited
Loading

closes #600

This PR

  • modifies MAKEFILES to allow generation of helm overlay
  • adds helm folder and overlay files
  • adds commands to generate CRDs into a separate crds folder
  • refactor operators to use a namespace taken from an ENV var
  • shows an example configuration to patch and env variable
  • patches the namespaces with the helm release.namespace

How to test

  • build your own images
  • then run make helm-package RELEASE_REGISTRY=<yours> TAG=<yours>
  • this will generate an up to date helm chart in helm/chart/charts
  • cd helm/chart && helm upgrade --install toolkit charts/keptn-lifecycle-toolkit-v0.5.0.tgz --namespace keptn-lifecycle --create-namespace
  • run e2e tests or integration tests to verify the installation make integration-test

@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #697 (1a2388b) into main (a9f41d7) will decrease coverage by 0.80%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   57.33%   56.54%   -0.80%     
==========================================
  Files          88       81       -7     
  Lines        7001     6528     -473     
==========================================
- Hits         4014     3691     -323     
+ Misses       2821     2711     -110     
+ Partials      166      126      -40
Impacted Files Coverage Δ
operator/controllers/common/providers/common.go 100.00% <100.00%> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 81.28% <100.00%> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 80.09% <0.00%> (-1.36%) ⬇️
...okcontroller/keptnwebhookcertificate_controller.go
klt-cert-manager/kubeutils/query.go
...rs/keptnwebhookcontroller/webhook_configuration.go
klt-cert-manager/kubeutils/certificates.go
klt-cert-manager/eventfilter/eventfilter.go
...llers/keptnwebhookcontroller/certificate_secret.go
... and 2 more
Flag Coverage Δ
keptn-cert-manager ?
keptn-lifecycle-operator 52.99% <12.50%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna self-assigned this Jan 25, 2023
@RealAnna RealAnna added this to the 0.6 milestone Jan 25, 2023
@RealAnna RealAnna marked this pull request as ready for review January 25, 2023 17:03
mowies
mowies reviewed Jan 26, 2023
View reviewed changes
helm/chart/values.yaml Outdated Show resolved Hide resolved
helm/overlay/kustomization.yaml Outdated Show resolved Hide resolved
helm/chart/values.yaml Outdated Show resolved Hide resolved
thisthat
thisthat reviewed Jan 26, 2023
View reviewed changes
helm/chart/Chart.yaml Outdated Show resolved Hide resolved
helm/chart/crds/lifecycle.keptn.sh_keptnapps.yaml Outdated Show resolved Hide resolved
mowies
mowies reviewed Jan 26, 2023
View reviewed changes
.github/actions/deploy-klt-on-cluster/action.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
operator/Makefile Outdated Show resolved Hide resolved
helm/overlay/kustomization.yaml Show resolved Hide resolved
helm/chart/Chart.yaml Outdated Show resolved Hide resolved
helm/chart/Chart.yaml Outdated Show resolved Hide resolved
helm/chart/Chart.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@RealAnna RealAnna force-pushed the feat/600/add_helm_overlay branch 2 times, most recently from 9302068 to 68aeb08 Compare January 27, 2023 07:35
RealAnna and others added 9 commits January 30, 2023 10:20
@RealAnna
helm overlay and makefile
cf3e514 
Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft of helm overlay

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added overlay and makefile

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>

added first draft

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
refactor namespace as an env var
23ce435 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
added gitignore
1bdb6b8 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @mowies
Update helm/chart/values.yaml
967070c 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
fix: security pipeline
c2f66d8 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: security pipeline
111b71c 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @thisthat
after review
563e83e 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update helm/chart/Chart.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update Makefile

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update Makefile

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update helm/chart/Chart.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

fix: security pipeline

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix: security pipeline

Signed-off-by: realanna <anna.reale@dynatrace.com>

Update helm/overlay/patches/patch_deployment.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update helm/overlay/kustomization.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update helm/overlay/patches/patch_deployment.yaml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update Makefile

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update .github/actions/deploy-klt-on-cluster/action.yml

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update helm/chart/Chart.yaml

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
fix: review
2bc1748 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: rebase
c4e0bb1 
Signed-off-by: realanna <anna.reale@dynatrace.com>
mowies
mowies reviewed Jan 30, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
helm/.gitignore Outdated Show resolved Hide resolved
RealAnna and others added 3 commits January 30, 2023 10:40
@RealAnna
fix: rebase
418abdf 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @mowies
Update helm/.gitignore
6ab2a08 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
fix: review
912ca67 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: review
711fafc 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: review
f4c6cf6 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: review
543bda9 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: review
3f8af96 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: review
9d9b8cb 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: review
1a2388b 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 9668ce8 into main Jan 30, 2023
@RealAnna RealAnna deleted the feat/600/add_helm_overlay branch January 30, 2023 12:16
@keptn-bot keptn-bot mentioned this pull request Jan 30, 2023
Merged
@thisthat thisthat mentioned this pull request Jan 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies left review comments

@thisthat thisthat thisthat approved these changes

@odubajDT odubajDT odubajDT approved these changes

@thschue thschue Awaiting requested review from thschue

@bacherfl bacherfl Awaiting requested review from bacherfl

@philipp-hinteregger philipp-hinteregger Awaiting requested review from philipp-hinteregger

Assignees

@RealAnna RealAnna

Labels
None yet
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

Set up helm chart through kustomize overlay
4 participants
@RealAnna @thisthat @mowies @odubajDT