Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): compute deployment interval on deployment endtime #842

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix(operator): compute deployment interval on deployment endtime #842

merged 1 commit into from
Feb 14, 2023

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes: #826

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT marked this pull request as ready for review February 14, 2023 14:26
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #842 (1208b72) into main (8249de6) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   58.63%   58.56%   -0.07%     
==========================================
  Files          97       97              
  Lines        7552     7552              
==========================================
- Hits         4428     4423       -5     
- Misses       2934     2937       +3     
- Partials      190      192       +2     
Impacted Files Coverage Δ
operator/controllers/common/metrics.go 79.41% <100.00%> (ø)
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 81.61% <0.00%> (-0.90%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 58.24% <0.00%> (+3.29%) ⬆️
Flag Coverage Δ
component-tests 41.79% <0.00%> (ø)
keptn-lifecycle-operator 54.67% <100.00%> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT merged commit 140b2f2 into keptn:main Feb 14, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 14, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interval deployment metric :: Decide on the baseline
3 participants