Standalone functions for generate pre/post processing for OPT #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Compared to #998 is there any difference here? Should this be the PR to move this functionality to the base classes? Or are we punting to be done in time for release? |
Base class, I was thinking to punt on till post release yeah. A fast follow up. Some interesting question on how much we pull into the base class. Especially with seq2seq coming. So this is just 1-1 with the same PR for GPT2 for now. |
mattdangerw
force-pushed
the
opt-standalone-preprocess
branch
from
f6c319d to
70d1531
Compare
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply mirroring changes in #998 for OPT, with the post-release plan still being to move most of this logic to a shared base class.