Fix a bug with computing the output mask after generate #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
approved these changes
May 11, 2023
| self.preprocessed_batch["padding_mask"][:, :5], | ||
| ) | ||
|
|
||
| def test_early_stopping(self): |
There was a problem hiding this comment.
Thanks for the test case, this is very cool
We were calling cumsum with the wrong axis, meaning we were not correctly masking all positions after an end token.
mattdangerw
force-pushed
the
fix-update-mask-computation
branch
from
a27e239 to
675fba6
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling
cumsumwith the wrong axis, meaning we were not correctly masking all positions after an end token.