Skip to content

Don't accept a string dtype for unicode tokenizer #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Don't accept a string dtype for unicode tokenizer #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7baff24
Don't accept a string dtype for unicode tokenizer
mattdangerw Apr 28, 2022
cbee8af
cast the output to the layer dtype
mattdangerw Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions keras_nlp/tokenizers/unicode_character_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ def __init__(
kwargs["dtype"] = tf.int32
else:
dtype = tf.dtypes.as_dtype(kwargs["dtype"])
if not dtype.is_integer and dtype != tf.string:
if not dtype.is_integer:
raise ValueError(
"Output dtype must be an integer type of a string. "
"Output dtype must be an integer type. "
f"Received: dtype={dtype}"
)

Expand Down Expand Up @@ -251,6 +251,7 @@ def tokenize(self, inputs):
replacement_char=self.replacement_char,
input_encoding=self.input_encoding,
)
tokens = tf.cast(tokens, self.compute_dtype)

if self.sequence_length:
output_shape = tokens.shape.as_list()
Expand Down