Skip to content

Rename max_length to sequence_length #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2022
Merged

Rename max_length to sequence_length #149

merged 1 commit into from
Apr 30, 2022

Conversation

mattdangerw
Copy link
Member

In the >90% use case (dense inputs) the value provided here will be
the sequence_length itself. This rename will improve the readability of
our hello world examples.

@mattdangerw
Rename max_length to sequence_length
c4cc82f 
In the >90% use case (dense inputs) the value provided here will be
the sequence_length itself. This rename will improve the readability of
our hello world examples.
chenmoneygithub
chenmoneygithub approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattdangerw mattdangerw merged commit 4b7a417 into keras-team:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chenmoneygithub chenmoneygithub chenmoneygithub approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @chenmoneygithub